Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41992 )
Change subject: [WIP] sb/intel: Always raise SMI with APM_CNT_FINALIZE
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41992/2/src/include/acpi/acpi.h
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/41992/2/src/include/acpi/acpi.h@103...
PS2, Line 1035: static inline int acpi_is_wakeup_s3(void) { return 0; }
We don't access CBMEM from ENV_SMM. So we don't have a usable romstage_handoff_is_resume() either.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41992
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b6450e0c8436e1c6113d54b7987b6b486908ed9
Gerrit-Change-Number: 41992
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 03 Jun 2020 03:13:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment