29 Jun
2020
29 Jun
'20
1:19 p.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42874 )
Change subject: mb/google/kahlee: Do not enable SCI for H1_PCH_INT_ODL ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42874/2/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/42874/2/src/mainboard/google/kahlee... PS2, Line 21: /* GPIO_9 - H1_PCH_INT_ODL, SCI */ remove SCI in comment?
https://review.coreboot.org/c/coreboot/+/42874/2/src/mainboard/google/kahlee... PS2, Line 30: /* GPIO_24 - EC_PCH_WAKE_L */ add SCI in comment?
--
To view, visit https://review.coreboot.org/c/coreboot/+/42874
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec2285b76f9c5fa1b4b1be15128fea316fa04555
Gerrit-Change-Number: 42874
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 29 Jun 2020 20:19:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment