4 Dec
2020
4 Dec
'20
10:09 p.m.
Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )
Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48286/5/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/48286/5/src/soc/intel/common/block/... PS5, Line 426: dl
Hi Tim, Furquan, shall I back up into edi and restore? what do you suggest is right thing to do here?
--
To view, visit https://review.coreboot.org/c/coreboot/+/48286
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iabf7f387fb5887aca10158788599452c3f2df7e8
Gerrit-Change-Number: 48286
Gerrit-PatchSet: 5
Gerrit-Owner: Shreesh Chhabbi shreesh.chhabbi@intel.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Shreesh Chhabbi shreesh.chhabbi@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-Comment-Date: Fri, 04 Dec 2020 20:09:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment