Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48280 )
Change subject: soc/intel/jasperlake: Enables CSE Lite driver for JSL platform in the romstage
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48280/6/src/soc/intel/jasperlake/ro...
File src/soc/intel/jasperlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/48280/6/src/soc/intel/jasperlake/ro...
PS6, Line 140: cse_fw_sync() must be called after DRAM initialization
It would be helpful to also add the information that HMRFPO (which is used by cse_fw_sync()) is expected to be executed only after DRAM initialization.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48280
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43030e77f6ede53c23e6c9e65d34db85c141e13a
Gerrit-Change-Number: 48280
Gerrit-PatchSet: 6
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 14 Dec 2020 04:55:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment