Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34518 )
Change subject: src/device/oprom src/lib: Remove broken bootsplash display code
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
If you wish to keep it, please fix it out of the device/oprom/ directory since we have other and better means to setup graphics framebuffer nowadays.
https://review.coreboot.org/c/coreboot/+/34518/6/src/device/oprom/realmode/x...
File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/c/coreboot/+/34518/6/src/device/oprom/realmode/x...
PS6, Line 375:
This makes me question Stefan's argument it is not limited to single resolution.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34518
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77619e1a885ed87123f4f5f185969d16d557e490
Gerrit-Change-Number: 34518
Gerrit-PatchSet: 6
Gerrit-Owner: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Tue, 23 Jul 2019 17:44:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment