Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39845 )
Change subject: ec/kontron: add option to configure I2C frequency ......................................................................
Patch Set 1:
(8 comments)
https://review.coreboot.org/c/coreboot/+/39845/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39845/1//COMMIT_MSG@12 PS1, Line 12: DMI parameters from EEPROM faster. Please mention some numbers? 50 milliseconds? 100 ms?
https://review.coreboot.org/c/coreboot/+/39845/1//COMMIT_MSG@14 PS1, Line 14: kontron Kontron
https://review.coreboot.org/c/coreboot/+/39845/1//COMMIT_MSG@14 PS1, Line 14: Tested on kontron COMe module with T10-TNI carrierboard [1,2] With what frequency?
https://review.coreboot.org/c/coreboot/+/39845/1//COMMIT_MSG@17 PS1, Line 17: [2] Missing URL/reference?
https://review.coreboot.org/c/coreboot/+/39845/1/src/ec/kontron/kempld/chip.... File src/ec/kontron/kempld/chip.h:
https://review.coreboot.org/c/coreboot/+/39845/1/src/ec/kontron/kempld/chip.... PS1, Line 35: unsigned short i2c_freq; Just use one space as in the struct above.
https://review.coreboot.org/c/coreboot/+/39845/1/src/ec/kontron/kempld/kempl... File src/ec/kontron/kempld/kempld_i2c.c:
https://review.coreboot.org/c/coreboot/+/39845/1/src/ec/kontron/kempld/kempl... PS1, Line 272: BIOS_INFO BIOS_WARNING
https://review.coreboot.org/c/coreboot/+/39845/1/src/ec/kontron/kempld/kempl... PS1, Line 273: Set Use?
https://review.coreboot.org/c/coreboot/+/39845/1/src/ec/kontron/kempld/kempl... PS1, Line 275: Maybe print out the used frequency as BIOS_INFO every time.