[coreboot-gerrit] Change in coreboot[master]: util/smc: Add and use new tool smcbiosinfo

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35484 )

Change subject: util/smc: Add and use new tool smcbiosinfo
......................................................................

Patch Set 9:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35484/9/util/smc/smcbiosinfo/smcbio... 
File util/smc/smcbiosinfo/smcbiosinfo.c:

https://review.coreboot.org/c/coreboot/+/35484/9/util/smc/smcbiosinfo/smcbio... 
PS9, Line 100: 			ret = 0;
> Usually it counts as failure, 0 should only be returned if the tool did it's job.

isn't printing a helpmessage doing it's job?

https://review.coreboot.org/c/coreboot/+/35484/9/util/smc/smcbiosinfo/smcbio... 
PS9, Line 164: 	memcpy(&sbu.boardid[1], CONFIG_SUPERMICRO_BOARDID, strlen(CONFIG_SUPERMICRO_BOARDID));
> this can overflow, how about MIN(sizeof(sbu.boardid) - 1, ... […]

check is on line 115