Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40578 )
Change subject: mb/google/volteer: move mipi_camera.asl to variants folders ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40578/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/40578/1/src/mainboard/google/voltee... PS1, Line 81: : config VARIANT_SPECIFIC_OPTIONS_HALVOR : def_bool n : : config VARIANT_SPECIFIC_OPTIONS_MALEFOR : def_bool n : : config VARIANT_SPECIFIC_OPTIONS_RIPTO : def_bool n : select VARIANT_HAS_MIPI_CAMERA : : config VARIANT_SPECIFIC_OPTIONS_VOLTEER : def_bool n : select VARIANT_HAS_MIPI_CAMERA
I don't think you need VARIANT_SPECIFIC_OPTIONS_*. […]
Done
https://review.coreboot.org/c/coreboot/+/40578/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/40578/1/src/mainboard/google/voltee... PS1, Line 53: #include <soc/intel/tigerlake/acpi/ipu.asl>
Checking now whether this will be required for USB-based camera. If it is, I will fix this CL.
I've confirmed that ipu.asl is only needed for mipi_camera, so the code is good to go as it is.