[coreboot-gerrit] Change in ...coreboot[master]: src/soc/intel/braswell/southcluster.c: Correct serial IRQ support

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29398 )

Change subject: src/soc/intel/braswell/southcluster.c: Correct serial IRQ support
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/29398/5/src/soc/intel/braswell/Kconfig 
File src/soc/intel/braswell/Kconfig:

https://review.coreboot.org/#/c/29398/5/src/soc/intel/braswell/Kconfig@137 
PS5, Line 137: 
             : config ENABLE_SERIRQ
             : 	bool "Enable Serial IRQ"
             : 	default n
             : 	help
             : 	  Enable Serial IRQ
             : 
             : config SERIRQ_CONTINUOUS_MODE
             : 	bool "Serial IRQ continuous mode"
             : 	default n
             : 	depends on ENABLE_SERIRQ
             : 	help
             : 	  Enable Serial IRQ continuous mode
> Supposed as user configurable, so visible and configurable in menuconfig.

are there boards which use this for which you'd want to disable it conditionally? If not, setting it at the board level vs user configurable makes more sense