insomniac has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42029 )
Change subject: smbios: Add option VPD_SMBIOS_VERSION that reads BIOS version from a VPD variable
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42029/8/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/42029/8/src/Kconfig@763
PS8, Line 763: default "firmware_version"
Hi Andrea (insomniac), is this config needed for you? […]
We don't have a strong requirement on making it configurable, and I am OK with either "version" or "firmware_version". My reasoning on making it configurable is to allow people to adapt it to their own scenario or naming scheme (e.g. smbios0_version? bios_version? system_firmware_version?). However if more people start using this feature I also understand that using a fixed name could be more desirable to avoid unpredictable behaviours, so I'm also OK with hardcoding it
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42029
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee62ed900095001ffac225fc629b3f2f52045e30
Gerrit-Change-Number: 42029
Gerrit-PatchSet: 13
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: insomniac
insomniac@slackware.it
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 22 Jun 2020 11:02:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment