Attention is currently required from: Angel Pons, Subrata Banik, Tarun Tuli.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76687?usp=email )
Change subject: soc/intel/alderlake: Disable PCIe clock gating
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/76687/comment/f7baed26_0f5ede91 :
PS1, Line 923: #if CONFIG(FSP_TYPE_IOT)
Huh, not fully awake yet... So, Client FSP doesn't have these UPDs yet? If so, this can be resolved.
That's correct. Once Intel releases a new Client FSP it will have the same UPDs and the preprocessor guard can be removed. It doesn't have them *yet*.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76687?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I673bbdbadc9afbed6a7bd5ce9f35dc70716d875b
Gerrit-Change-Number: 76687
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 10 Aug 2023 07:58:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment