Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37069 )
Change subject: trogdor: add support for Bubs variant ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/Kconfig:
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo... PS1, Line 18: select MAINBOARD_HAS_CHROMEOS We'll also need a
select MAINBOARD_HAS_SPI_TPM_CR50 if !BOARD_GOOGLE_BUBS select MAINBOARD_HAS_TPM2 if !BOARD_GOOGLE_BUBS
here to make the TPM work.
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo... PS1, Line 36: default 0x5 Looks like this needs to be 0x0 for Trogdor now.
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo... PS1, Line 40: default 0xa And this needs to be 0x8