Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43673 )
Change subject: soc/intel/jasperlake: Fix PMC_GPE_DW mapping
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43673/4/src/soc/intel/jasperlake/in...
File src/soc/intel/jasperlake/include/soc/pmc.h:
https://review.coreboot.org/c/coreboot/+/43673/4/src/soc/intel/jasperlake/in...
PS4, Line 105: #define PMC_GPP_G 0x0
: #define PMC_GPP_B 0x1
: #define PMC_GPP_A 0x2
: #define PMC_GPP_R 0x3
: #define PMC_GPP_S 0x4
: #define PMC_GPD 0x5
: #define PMC_GPP_H 0x6
: #define PMC_GPP_D 0x7
: #define PMC_GPP_F 0x8
: #define PMC_GPP_C 0xA
: #define PMC_GPP_E 0xB
Checking on the same, Karthik. Will get back asap.
Hi Karthik, is it okay to attach the snippet of the doc for code review? We are working on the access.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43673
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59ce3720e0ffeefb2c9440bb300689def80211ea
Gerrit-Change-Number: 43673
Gerrit-PatchSet: 4
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 10 Aug 2020 06:40:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Meera Ravindranath
meera.ravindranath@intel.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment