5 Oct
2019
5 Oct
'19
12:33 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35750 )
Change subject: Increase range of our main Frequency_Type ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/35750/2/common/hw-gfx-gma-pch-vga... File common/hw-gfx-gma-pch-vga.adb:
https://review.coreboot.org/c/libgfxinit/+/35750/2/common/hw-gfx-gma-pch-vga... PS2, Line 138: Div_Sel := Word32 (Refclock / Mode.Dotclock) - 2;
It's the truth I tried to avoid. With `Mode.Dotclock` being possibly […]
I would prefer if this were to be proven rather than relying on overflow handling behavior
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/35750
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I3a159bc11ccadcaba8ad04e126e6feadfd46008e
Gerrit-Change-Number: 35750
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 05 Oct 2019 00:33:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment