Attention is currently required from: Arthur Heymans, Raul Rangel, Nico Huber, Martin Roth, Tim Wawrzynczak, Rob Barnes, Karthik Ramasubramanian.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62355 )
Change subject: cpu/x86/smm,lib/cbmem_console: Enable CBMEMC when using DEBUG_SMI
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/c/coreboot/+/62355/comment/bb9b3812_5820aff5
PS3, Line 562: cbmemc = cbmem_entry_find(CBMEM_ID_CONSOLE);
nit: wrap in `if (CONFIG_CONSOLE_CBMEM)`?
File src/lib/cbmem_console.c:
https://review.coreboot.org/c/coreboot/+/62355/comment/03641bc8_b1e5fbf6
PS3, Line 93: if (cbmemc != NULL && cbmemc_size > 0)
nit: init_console_ptr() already checks both of these
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62355
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1e310a12ca2f54210ccfaee58807cb808cfff79
Gerrit-Change-Number: 62355
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 03 Mar 2022 01:06:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment