Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36452 )
Change subject: hatch: Create puff variant
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36452/4/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/puff/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36452/4/src/mainboard/google/hatch/...
PS4, Line 3: *
While you're addressing Furquan's comments can you add
Copyright 2019 Google LLC
:)
https://review.coreboot.org/c/coreboot/+/36452/4/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/puff/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/36452/4/src/mainboard/google/hatch/...
PS4, Line 3: *
Same here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36452
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6449c4fcc1df702ed4f0d35afd7b0981e4c72323
Gerrit-Change-Number: 36452
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 Nov 2019 05:38:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment