Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43790 )
Change subject: mb/google/volteer: Update flashmap descriptor for CSE Lite FW update
......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2:
This breaks the update flow, right? Any coordination needed here?
Can you share more information why this breaks the update flow? Thanks.
firmware updates overwrite one of the RW_SECTION_[AB] regions, keeping everything else intact but that requires that they keep their location and size.
I'm not sure at which state this device is, and if there are any such incremential updates already. If not (and all updates are always full rewrites) there's no issue, otherwise we might have to look into it.
Thanks for comments. Can I have comments from others reviewers regarding this?
To enable CSE FW update, I think FMD update is required anyway to reserve enough space for RW_SECTION_A/B, and it is better FMD change is done sooner. Any comments would be appreciated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43790
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3c2b657f0426d206dfe3729829ec34ff57812c7
Gerrit-Change-Number: 43790
Gerrit-PatchSet: 2
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 30 Aug 2020 06:42:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment