Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45930 )
Change subject: soc/intel/common/block/systemagent/memmap.c: Align cached region
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45930/4/src/soc/intel/common/block/...
File src/soc/intel/common/block/systemagent/memmap.c:
https://review.coreboot.org/c/coreboot/+/45930/4/src/soc/intel/common/block/...
PS4, Line 59: FSP does not seem to bother w.r.t. alignment when asked to place cbmem_top()
I think FSP-M places some data below the real TOLUD and reports the top below that, which explains the weird alignment.
Basically what the picture above lists between TSEG and TOLUM. The list
should be accurate, we acted on that information for a while and it worked
out mostly. Until we decided to just use FSP's HOP entry.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45930
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic64fd6d3d9e8ab4c78d68b910a476f9c4eb2d353
Gerrit-Change-Number: 45930
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 03 Nov 2020 17:08:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment