build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44868 )
Change subject: sc7180 : report hardware watchdog reset after reboot ......................................................................
Patch Set 8:
(8 comments)
https://review.coreboot.org/c/coreboot/+/44868/8/src/soc/qualcomm/sc7180/soc... File src/soc/qualcomm/sc7180/soc.c:
https://review.coreboot.org/c/coreboot/+/44868/8/src/soc/qualcomm/sc7180/soc... PS8, Line 32: if(aoss & WDOG_RESET_BIT_MASK) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/44868/8/src/soc/qualcomm/sc7180/wat... File src/soc/qualcomm/sc7180/watchdog.c:
https://review.coreboot.org/c/coreboot/+/44868/8/src/soc/qualcomm/sc7180/wat... PS8, Line 11: uint32_t wdog_sta; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44868/8/src/soc/qualcomm/sc7180/wat... PS8, Line 11: uint32_t wdog_sta; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/44868/8/src/soc/qualcomm/sc7180/wat... PS8, Line 12: wdog_sta = read32(&aoss->aoss_cc_reset_status); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44868/8/src/soc/qualcomm/sc7180/wat... PS8, Line 12: wdog_sta = read32(&aoss->aoss_cc_reset_status); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/44868/8/src/soc/qualcomm/sc7180/wat... PS8, Line 14: printk(BIOS_INFO, "\nWDOG: Last reset was AOSS_CC_RESET_STATUS : %x\n", wdog_sta & WDOG_RESET_BIT_MASK); line over 96 characters
https://review.coreboot.org/c/coreboot/+/44868/8/src/soc/qualcomm/sc7180/wat... PS8, Line 14: printk(BIOS_INFO, "\nWDOG: Last reset was AOSS_CC_RESET_STATUS : %x\n", wdog_sta & WDOG_RESET_BIT_MASK); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44868/8/src/soc/qualcomm/sc7180/wat... PS8, Line 14: printk(BIOS_INFO, "\nWDOG: Last reset was AOSS_CC_RESET_STATUS : %x\n", wdog_sta & WDOG_RESET_BIT_MASK); please, no spaces at the start of a line