Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36609 )
Change subject: mb/google/hatch/variants/helios: Update TSR3 sensor thresholds
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36609/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36609/2/src/mainboard/google/hatch/...
PS2, Line 39: #define DPTF_TSR3_PASSIVE 90
: #define DPTF_TSR3_CRITICAL 105
: #define DPTF_TSR3_ACTIVE_AC0 87
: #define DPTF_TSR3_ACTIVE_AC1 85
: #define DPTF_TSR3_ACTIVE_AC2 83
: #define DPTF_TSR3_ACTIVE_AC3 80
: #define DPTF_TSR3_ACTIVE_AC4 78
: #define DPTF_TSR3_ACTIVE_AC5 75
I thought when the thresholds were set to 0, that meant the the particular threshold was not used? Did the 5 degree change in both _PASSIVE and _CRITICAL make that much of a difference?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36609
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia417f8c51442005cc8c2251c188cebc197e0a773
Gerrit-Change-Number: 36609
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Scott Collyer
scollyer@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 04 Nov 2019 17:39:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment