Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Grzegorz Bernacki, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74268 )
Change subject: mendocino: Generate FSP version file
......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
I think you should squash this commit with CB:74267.
File src/soc/amd/mendocino/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/74268/comment/013310f0_10970478
PS1, Line 220: CONFIG_FSP_VERSION_FILE
note: This will have to change if you apply changes I suggested in CB:74267.
https://review.coreboot.org/c/coreboot/+/74268/comment/203e012c_40d02c53
PS1, Line 220: $(FSP_VERSION_FILE)
Please add quotes around `$(FSP_VERSION_FILE)`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74268
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id1a27261e1b88a26732fbb4efaf1a8a0a7158140
Gerrit-Change-Number: 74268
Gerrit-PatchSet: 1
Gerrit-Owner: Grzegorz Bernacki
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Grzegorz Bernacki
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 07 Apr 2023 11:09:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment