Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37924 )
Change subject: soc/mediatek/mt8183: Restore vcore after DRAM calibration
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37924/1/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/37924/1/src/mainboard/google/kukui/...
PS1, Line 79: pmic_set_vcore_vol(800000);
Would it be better to restore vcore in soc/mediatek/mt8183?
I moved this to memory.c in patchset 5.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37924
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia87b4ac78a32dbd4c4ab52e84d307cb46525afa1
Gerrit-Change-Number: 37924
Gerrit-PatchSet: 5
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 26 Dec 2019 03:53:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment