Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38718 )
Change subject: mb/google/drallion: Update IA VR TDC current limit
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38718/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38718/3//COMMIT_MSG@10
PS3, Line 10: and follow b:148912093#comment1.
Yes.
Pls fix the commit msg. it's not clear.
You can probably say.
Dralion HW is using baseline config, so this commit sets baseline IA TDC limit for U42/U62 accordingly.
Thanks.
https://review.coreboot.org/c/coreboot/+/38718/3/src/mainboard/google/dralli...
File src/mainboard/google/drallion/ramstage.c:
https://review.coreboot.org/c/coreboot/+/38718/3/src/mainboard/google/dralli...
PS3, Line 42: params->TdcPowerLimit[1] = VR_CFG_TDC(48);
I check FSP log. […]
i made some comments in the issue tracker according to your log.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38718
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a80fb4fd0a9bd9bc343c1c0c7b47bb947fca226
Gerrit-Change-Number: 38718
Gerrit-PatchSet: 4
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Marx Wang
marx.wang@intel.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: JoeJ Chang
joej_chang@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 06 Feb 2020 09:49:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Kane Chen
kane.chen@intel.com
Comment-In-Reply-To: John Su
john_su@compal.corp-partner.google.com
Gerrit-MessageType: comment