Attention is currently required from: Felix Singer, Jérémy Compostella, Lean Sheng Tan, Subrata Banik.
Himanshu Sahdev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75552?usp=email )
Change subject: include/cpu/x86: Simplify en/dis cache functions
......................................................................
Patch Set 2:
(1 comment)
File src/include/cpu/x86/cache.h:
https://review.coreboot.org/c/coreboot/+/75552/comment/6c3ed77b_341159b5 :
PS2, Line 48: CR0_CacheDisable
can we avoid camel case?
want me to change it to screaming snake case -> CR0_CACHE_DISABLE?
Also, these macros being in use already, better to do it in different CL to change everywhere.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75552?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81688e8bbb073e1d09ecf63f3f33e1651dbd778e
Gerrit-Change-Number: 75552
Gerrit-PatchSet: 2
Gerrit-Owner: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Thu, 01 Jun 2023 06:01:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment