Attention is currently required from: Felix Singer, Máté Kukri.
Angel Pons has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/82053?usp=email )
Change subject: [WIP] OptiPlex 3050 port
......................................................................
Patch Set 11:
(2 comments)
File src/mainboard/dell/optiplex_3050/acpi/dptf.asl:
PS11:
i think i saw a dmesg about it, but otherwise no.
I would remove it then. I'm not sure if DPTF is of much use on desktops anyway.
https://review.coreboot.org/c/coreboot/+/82053/comment/01e81f5b_f4921f2f?usp... :
PS11, Line 13: Package () { _SB.PCI0.B0D4, _SB.PCI0.B0D4, 100, 50, 0, 0, 0, 0 },
I mean... This device is not enabled in the devicetree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82053?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8d443e39ee684a4eaa19c835a945cfe569c051e2
Gerrit-Change-Number: 82053
Gerrit-PatchSet: 11
Gerrit-Owner: Máté Kukri
kukri.mate@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Máté Kukri
kukri.mate@gmail.com
Gerrit-Comment-Date: Sun, 30 Jun 2024 14:14:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Máté Kukri
kukri.mate@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com