Attention is currently required from: Jason Glenesk, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50512 )
Change subject: soc/amd: add and use fch_enable_hpet_decode
......................................................................
Patch Set 2:
(2 comments)
File src/soc/amd/common/block/acpimmio/mmio_util.c:
https://review.coreboot.org/c/coreboot/+/50512/comment/06570a67_ba00e35a
PS2, Line 79: HPET_FED0_EN
I feel like we should enable hpet_msi_en and hpet_width_sel.
# pm-regs 0x00
PMx00 PmDecodeEn => 0xe3060bf7
29 => 1: HpetMsiEn
28 => 0: HpetWidthSel
We don't currently set 64-bit HPET on picasso.
File src/soc/amd/common/block/include/amdblocks/acpimmio.h:
https://review.coreboot.org/c/coreboot/+/50512/comment/9dee5b21_451464aa
PS2, Line 20: FED0
FED0?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50512
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie98dae1d6036748f700f884d4b9653f2e59c24da
Gerrit-Change-Number: 50512
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 11 Feb 2021 20:26:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment