[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/uart: rework to use dummy device

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48385 )

Change subject: soc/intel/common/block/uart: rework to use dummy device
......................................................................

Patch Set 3:
> Patch Set 3:
> > Patch Set 3:
> > > Patch Set 3: Code-Review-2
> > >
> > > I can't say if this is working, or even if it can work.
> >
> > I wonder how this one is different from drivers/wifi/generic, which uses the same dummy model?
>
> Except it doesn't? It does not use a generic device below
> a PCI device. And it checks the device path so it doesn't
> attach PCI ops to a non-PCI device in the first place.

What is this then?

device pci 14.3 on
    		chip drivers/wifi/generic
    			register "wake" = "GPE0_PME_B0"
    			device generic 0 on end
    		end
    	end  # CNVi wifi

You really should check the history of drivers/wifi/generic, commit d436750 for example...
> > > Another idea to solve one of the issues this chip driver
> > > currently handles: Allow to specify the PCI IDs in the
> > > devicetree if the device is `hidden`.
> >
> > Huh, that is already possible (devid)
>
> I meant a proper solution, not a "register" hack.