Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46435 )
Change subject: cpu/x86/mtrr: add support for address space higher than 16TiB ......................................................................
Patch Set 4:
(2 comments)
Thanks for the review!
https://review.coreboot.org/c/coreboot/+/46435/4/src/cpu/x86/mtrr/mtrr.c File src/cpu/x86/mtrr/mtrr.c:
https://review.coreboot.org/c/coreboot/+/46435/4/src/cpu/x86/mtrr/mtrr.c@120 PS4, Line 120: 1
Update this as well?
MTRR_TAG_MASK is only used inrange_entry_mtrr_type(): return range_entry_tag(r) & MTRR_TAG_MASK;
range_entry_tag() returns (unsigned) long. So we do not need to update this with ULL.
https://review.coreboot.org/c/coreboot/+/46435/4/src/cpu/x86/mtrr/mtrr.c@463 PS4, Line 463: return fms(x >> 32) + 32;
Did you double check the semantics of fls and fms? I recall those being sorta odd. […]
Done