[coreboot-gerrit] Change in coreboot[master]: soc/intel/jasperlake: Log PM event from an internal device

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47226 )

Change subject: soc/intel/jasperlake: Log PM event from an internal device
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/47226/1/src/soc/intel/jasperlake/el... 
File src/soc/intel/jasperlake/elog.c:

https://review.coreboot.org/c/coreboot/+/47226/1/src/soc/intel/jasperlake/el... 
PS1, Line 16: #ifdef __SIMPLE_DEVICE__
            : 	pci_devfn_t dev;
            : #else
            : 	struct device *dev;
            : #endif
> I think we can use `pci_devfn_t` irrespective of __SIMPLE_DEVICE__. Keeps code free of #ifdefs.

Done

https://review.coreboot.org/c/coreboot/+/47226/1/src/soc/intel/jasperlake/el... 
PS1, Line 21: reg_offset
> I added a `pci_s_dev_is_wake_source` function for the simple device model (used in SMM) for elog, wo […]

Done