HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37876 )
Change subject: src: Add comments on deprecated 'Processor()'
......................................................................
Patch Set 8:
(1 comment)
Patch Set 8:
(1 comment)
Personal I believe to put the warning in build time to warn developer will be better? I believe current ASL already support that?
currently, Jenkins is running very old IASL version. so no warning is issued until we send a patch to upgrade IASL toolchain
https://review.coreboot.org/c/coreboot/+/37876/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37876/8//COMMIT_MSG@9
PS8, Line 9: ACPI specification,
From which revision?
IASL version 20190816
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37876
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9ea2ed6a2128dc4fe94155d098c2a4f7c24d82f
Gerrit-Change-Number: 37876
Gerrit-PatchSet: 8
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lance Zhao
lance.zhao@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 13 Jan 2020 18:50:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lance Zhao
lance.zhao@gmail.com
Gerrit-MessageType: comment