Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36945 )
Change subject: mb/google/kahlee/treeya: Set touchpad hold time to 400ns ......................................................................
Patch Set 4:
(6 comments)
https://review.coreboot.org/c/coreboot/+/36945/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36945/1//COMMIT_MSG@8 PS1, Line 8: than 300ns
Just for the record, multi-line git subjects are well-defined. […]
Done
https://review.coreboot.org/c/coreboot/+/36945/1//COMMIT_MSG@10 PS1, Line 10: need tune
need to tune
Done
https://review.coreboot.org/c/coreboot/+/36945/1//COMMIT_MSG@10 PS1, Line 10: SI
What does that mean?
According to the chip manufacturer (silicon team)
https://review.coreboot.org/c/coreboot/+/36945/1//COMMIT_MSG@11 PS1, Line 11: more than 300ns
Why do you increase it to 400 ns then? […]
400ns > 300ns There is no default value - how long is a piece of string?
https://review.coreboot.org/c/coreboot/+/36945/1//COMMIT_MSG@14 PS1, Line 14: masure
measure
Done
https://review.coreboot.org/c/coreboot/+/36945/1//COMMIT_MSG@14 PS1, Line 14: TEST=build firmware and masure I2C bus2 data hold time
How did you measure it?
The normal way is with an Oscilloscope.