10 Nov
2020
10 Nov
'20
6:26 a.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47235 )
Change subject: drivers/i2c/rx6110sa: Add basic ACPI support ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47235/3/src/drivers/i2c/rx6110sa/rx... File src/drivers/i2c/rx6110sa/rx6110sa.c:
https://review.coreboot.org/c/coreboot/+/47235/3/src/drivers/i2c/rx6110sa/rx... PS3, Line 180: .speed = config->bus_speed ? : I2C_SPEED_FAST,
If there is nothing defined in config->bus_speed (bus_speed=0), then the maximum supported bus speed […]
Maybe add some code somewhere to throw a warning if it's an unexpected value and fall back to slow?
--
To view, visit https://review.coreboot.org/c/coreboot/+/47235
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b319e3088e6511592075b055f8fa3e2aedaa209
Gerrit-Change-Number: 47235
Gerrit-PatchSet: 3
Gerrit-Owner: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: Johannes Hahn johannes-hahn@siemens.com
Gerrit-Reviewer: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: siemens-bot
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-Comment-Date: Tue, 10 Nov 2020 06:26:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com
Comment-In-Reply-To: Werner Zeh werner.zeh@siemens.com
Gerrit-MessageType: comment