Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31428 )
Change subject: mb/google/laser: Disable touch screen device that according to SKU ID ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31428/3/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/phaser/gpio.c:
https://review.coreboot.org/#/c/31428/3/src/mainboard/google/octopus/variant... PS3, Line 77: if ((sku_id == 1) || (sku_id == 6)) { we should really create a phaser level function that e.g. is_touchscreen_sku() that encodes this, so we don't have to keep two places in sync
https://review.coreboot.org/#/c/31428/3/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/phaser/variant.c:
https://review.coreboot.org/#/c/31428/3/src/mainboard/google/octopus/variant... PS3, Line 33: SKU ID 1 comment is out of date