Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44782 )
Change subject: fw_config: Add caching to successfully probed fields
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44782/4/src/lib/fw_config.c
File src/lib/fw_config.c:
https://review.coreboot.org/c/coreboot/+/44782/4/src/lib/fw_config.c@85
PS4, Line 85: mask
Something to keep in mind is that not everything would necessarily be a boolean. It could be value based. This code would still work, but we may want to call that out.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44782
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d014206a4ee6cc7592e12e704a7708652330eaf
Gerrit-Change-Number: 44782
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Caveh Jalali
caveh@chromium.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 26 Aug 2020 20:02:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment