Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39129 )
Change subject: Documentation: Tutorial me_cleaner on Lenovo devices ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39129/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39129/2//COMMIT_MSG@7 PS2, Line 7: Documentation: Tutorial me_cleaner on Lenovo devices Statement please:
Add me_cleaner tutorial on Lenovo devices
https://review.coreboot.org/c/coreboot/+/39129/2/Documentation/mainboard/len... File Documentation/mainboard/lenovo/Sandy_Bridge_series.md:
https://review.coreboot.org/c/coreboot/+/39129/2/Documentation/mainboard/len... PS2, Line 49: It is possible to reduce the Intel ME firmware size to free additional : space for the `bios` region. This is usually refered to as *cleaning the ME* or : *stripping the ME*. See general notes on [me_cleaner]. : : With the reduced Intel ME firmware the IFD, GbE and ME regions require : less than 128 KiB of space in the ROM. : : The modified flash layout needs to be written to IFD! : Have a look at the [ME tutorial] for more information. : : Tests on Lenovo X220 showed no issues with a stripped ME firmware. Reflow the lines?
https://review.coreboot.org/c/coreboot/+/39129/2/Documentation/mainboard/len... File Documentation/mainboard/lenovo/stripping_me.md:
https://review.coreboot.org/c/coreboot/+/39129/2/Documentation/mainboard/len... PS2, Line 14: `bios` region. Should the text be duplicated?
https://review.coreboot.org/c/coreboot/+/39129/2/Documentation/mainboard/len... PS2, Line 53: Add a note, what the difference to the Kconfig integration of me_cleaner is?