Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45217 )
Change subject: xeon_sp: Move common acpi code to xeon_sp/
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45217/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45217/1//COMMIT_MSG@10
PS1, Line 10: whitespace differences between the directories.
Does this change the resulting binaries for mainboards using the skx/cpx ACPI code?
I failed to notice the IRQ routing difference. I'll update that on skx first so that this change doesn't change the binary.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45217
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5058a3fe8d96075a266fb92f10707bb94308c85b
Gerrit-Change-Number: 45217
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 10 Sep 2020 16:32:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment