Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39893 )
Change subject: Documentation: Add proposal for firmware unit testing ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39893/1/Documentation/technotes/202... File Documentation/technotes/2020-03-unit-testing-coreboot.md:
https://review.coreboot.org/c/coreboot/+/39893/1/Documentation/technotes/202... PS1, Line 52: This dependencies : may be broken using mocking concept, to some degree. However when mocks need to : be too complex, then such a unit test cannot address an idea of being quick and : simple.
Makes sense, wasn't clear enough here. […]
I like the simple version you propose.
My statement about "unrelated changes" has to do with a unit test that is too closely tied to the implementation of the module under test. I've seen it happen mainly when testing a state machine; the unit test checks the state, instead of checking the outputs. So it's just something to be aware of when writing tests, to avoid testing internals of the code.
https://review.coreboot.org/c/coreboot/+/39893/1/Documentation/technotes/202... PS1, Line 94: Assumption that all firmware devs know C
My point is - ideally tests should be written in C, since this is the language which all coreboot de […]
OK, then state that instead, that unit tests will be written in C because the code being tested is also written in C.