[coreboot-gerrit] Change in coreboot[master]: drivers/pcie/rtd3/device: Add PCIe RTD3 driver

[Raul Rangel (Code Review)]

Attention is currently required from: Jason Glenesk, Furquan Shaikh, Marshall Dawson, Tim Wawrzynczak, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54966 )

Change subject: drivers/pcie/rtd3/device: Add PCIe RTD3 driver
......................................................................

Patch Set 4:

(1 comment)

File src/soc/amd/common/block/rtd3/rtd3.c:

https://review.coreboot.org/c/coreboot/+/54966/comment/e1a9e587_d3400387 
PS1, Line 210: pci_dev_read_resources
> Also, if the drivers/pcie/rtd3/ is supposed to be any kind of PCIe device, then it might have to support all the operations including pci_rom* operations too.

So if rtd3 needs to generate the node it gets a little tricky for cases like this:

device ref gpp_bridge_0 on
    		chip drivers/wifi/generic
    			register "wake" = "GEVENT_8"
    			device pci 00.0 alias wifi on end
    		end

# Test so the Wifi can be placed into D3
    		chip drivers/pcie/rtd3/device
    			use wifi as target
    			register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_5)"
    			register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_29)"
    			register "reset_delay_ms" = "100"
    			register "reset_off_delay_ms" = "1"
    			device generic 0 on end
    		end
    	end # WLAN

The wifi/generic driver handles creating the ACPI Device, so rtd3 can't create a duplicate device. Should I make the rtd3 driver check if config->target->ops->acpi_fill_ssdt == NULL, and then generate the PCI ACPI node, otherwise just write into the device scope?