build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33772 )
Change subject: [WIP] NOTFORMERGE mb/amd/mandolin: Add Picasso CRB
......................................................................
Patch Set 31:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33772/31/src/mainboard/amd/mandolin...
File src/mainboard/amd/mandolin/mainboard.c:
https://review.coreboot.org/c/coreboot/+/33772/31/src/mainboard/amd/mandolin...
PS31, Line 147: if (!CONFIG(PICASSO_LPC_IOMUX)) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/33772/31/src/mainboard/amd/mandolin...
PS31, Line 245: {
that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/33772/31/src/mainboard/amd/mandolin...
PS31, Line 301: {
that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/33772/31/src/mainboard/amd/mandolin...
PS31, Line 325: {
that open brace { should be on the previous line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33772
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b4a78e1eef9f998e1986da1506201eb505822eb
Gerrit-Change-Number: 33772
Gerrit-PatchSet: 31
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zheng Bao
zheng.bao@amd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 30 May 2020 00:14:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment