[coreboot-gerrit] Change in coreboot[master]: arch/x86: Don't use .bss from car.ld if not running XIP

[Arthur Heymans (Code Review)]

Attention is currently required from: Nico Huber, Furquan Shaikh, Marshall Dawson, Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48156 )

Change subject: arch/x86: Don't use .bss from car.ld if not running XIP
......................................................................

Patch Set 3:

(3 comments)

File src/arch/x86/assembly_entry.S:

https://review.coreboot.org/c/coreboot/+/48156/comment/7c2847c9_350ec9b4 
PS2, Line 39: #if ENV_STAGE_XIP
> > Same question for .data, although I don't see how one could re-initialise it. So .data becomes persistent across S3 suspend for bootblock(+romstage) ?
>
> The resume path already clears .bss.
>
> For the data section it looks like we would need to save it somewhere and restore it on the S3 path? Assuming we want a .data section in the first stage of course.

Done. Now this only targets ROMSTAGE & VERSTAGE.

File src/include/rules.h:

https://review.coreboot.org/c/coreboot/+/48156/comment/d6eadfad_f0979837 
PS1, Line 266: ENV_ROMSTAGE || ENV_SEPARATE_VERSTAGE
> If we want to cover the bootblock, that could be more explicit: […]

Done

https://review.coreboot.org/c/coreboot/+/48156/comment/e7bf0871_5fa44c1b 
PS1, Line 276: stages uses
> nit - maybe "stage uses".

Done