Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42512 )
Change subject: mb/pcengines/apu1/mainboard.c: fix apu1 serial number counting
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42512/1/src/mainboard/pcengines/apu...
File src/mainboard/pcengines/apu1/mainboard.c:
https://review.coreboot.org/c/coreboot/+/42512/1/src/mainboard/pcengines/apu...
PS1, Line 4: #include <AGESA.h>
git grep "Porting.h"
/* warning: Porting.h includes an open #pragma pack(1) */
If at all possible, avoid <AGESA.h> and <AMD.h> includes. If you need it, place them as the last include.
6ebb739 mb/pcengines/apu1/mainboard.c: Add SMBIOS type 16 and 17 entries
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42512
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e8690d100b38ac7889395d375c0ff32bdefda0b
Gerrit-Change-Number: 42512
Gerrit-PatchSet: 1
Gerrit-Owner: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 28 Jun 2020 15:55:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment