[coreboot-gerrit] Change in ...coreboot[master]: Kconfig: Add system type entries for convertible and tablet

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31206 )

Change subject: Kconfig: Add system type entries for convertible and tablet
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31206/1/src/Kconfig 
File src/Kconfig:

https://review.coreboot.org/#/c/31206/1/src/Kconfig@334 
PS1, Line 334: config SYSTEM_TYPE_LAPTOP
> Should this be a 'choice' block (with a fourth SYSTEM_TYPE_DESKTOP added as the default)?

I thought about that but is choice meant to have user-visible options?

I also ran into issues trying to 'select' something in the board Kconfig.  There has to be an example of this somewhere..