Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38849 )
Change subject: soc/intel/common: Update Jasperlake Device IDs
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38849/5/src/include/device/pci_ids....
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/38849/5/src/include/device/pci_ids....
PS5, Line 3394: JSL
All the IDs use JSP and this ID uses JSL. Can you please keep it consistent with other IDs?
Also while you are at it, do you need to re-index GT1 to GT0 & GT2 to GT1. I am not an expert here. It is your call.
https://review.coreboot.org/c/coreboot/+/38849/5/src/include/device/pci_ids....
PS5, Line 3453: #define PCI_DEVICE_ID_INTEL_JSL_EHL 0x4532
: #define PCI_DEVICE_ID_INTEL_EHL_ID_1 0x4510
Done
The confusion happened because of JSL_EHL. So I thought it has some relation with Jasper Lake. Can you please confirm that ID has got nothing to do with Jasper Lake.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38849
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c9ec1eb4236184b981d99250f263172c82f7117
Gerrit-Change-Number: 38849
Gerrit-PatchSet: 6
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 13 Feb 2020 18:46:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-MessageType: comment