Attention is currently required from: Manoj Gupta, Paul Menzel. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63936 )
Change subject: utils/cbfstool: Disable Wstrict-prototypes warning ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Can the LZ4 code be updated instead? […]
I don't want the LZ4 code to diverge from upstream. If someone has time to fix this upstream (if it hasn't already) and then pull back and test an uprev here, they're welcome to do that and we can revert this again. Until then I think this is a reasonable solution. There's no reason for us to waste extra time on warnings about stuff in code that a) has always been there to begin with (and is only now getting called out because of clang's questionable over-interpretations of long-standing warning settings) and b) we don't plan to do any independent development on anyway (so what's even the point in warning about style stuff in code that doesn't change).