Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34297 )
Change subject: src: Make implicit fall throughs explicit ......................................................................
Patch Set 5:
(13 comments)
OCD is good ;)
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f12/Proc/CPU/S3.c:
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... PS4, Line 228: F
My OCD kindly says: Please be consistent, the rest of instances are not capitalized. […]
Done
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f12/Proc/Mem/NB/mnphy.c:
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... PS4, Line 820: fallthrough
Missing a space!
Done
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f14/Proc/CPU/S3.c:
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... PS4, Line 230: F
More capitalized inconsistency ;-;
Done
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... PS4, Line 676: F
Same
Done
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... PS4, Line 736: F
Same
Done
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f15tn/Proc/CPU/S3.c:
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... PS4, Line 227: F
Same (this looks familiar... […]
Done
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... PS4, Line 681: F
Same
Done
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... PS4, Line 741: F
Same
Done
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f15tn/Proc/Mem/Main/muc.c:
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... PS4, Line 214: fallthrough
Missing a space?
Done
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... PS4, Line 222: fallthrough
ditto
Done
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f16kb/Proc/CPU/S3.c:
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... PS4, Line 227: F
Same (how many copies of this file do we have?)
Done
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... PS4, Line 681: F
Same
Done
https://review.coreboot.org/c/coreboot/+/34297/4/src/vendorcode/amd/agesa/f1... PS4, Line 741: F
Same
Done