Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31108 )
Change subject: sb/intel/common/firmware: Don't call GbE binary `firmware` ......................................................................
sb/intel/common/firmware: Don't call GbE binary `firmware`
Unless things changed considerably, this file doesn't contain any firmware. It is merely replacing a configuration EEPROM for the MAC address etc. So don't call it firmware.
Change-Id: Ife6190639e7f05da2cb6eddeb1b0db0e8ffc8e6e Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/31108 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Tristan Corrick tristan@corrick.kiwi Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Subrata Banik subrata.banik@intel.com --- M src/southbridge/intel/common/firmware/Kconfig 1 file changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved Arthur Heymans: Looks good to me, approved Subrata Banik: Looks good to me, approved Tristan Corrick: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/southbridge/intel/common/firmware/Kconfig b/src/southbridge/intel/common/firmware/Kconfig index ba54fcd..31a3df3 100644 --- a/src/southbridge/intel/common/firmware/Kconfig +++ b/src/southbridge/intel/common/firmware/Kconfig @@ -111,15 +111,15 @@ def_bool n
config HAVE_GBE_BIN - bool "Add gigabit ethernet firmware" + bool "Add gigabit ethernet configuration" depends on HAVE_IFD_BIN && MAINBOARD_USES_IFD_GBE_REGION help - The integrated gigabit ethernet controller needs a firmware file. - Select this if you are going to use the PCH integrated controller - and have the firmware. + The integrated gigabit ethernet controller needs a configuration + file. Select this if you are going to use the PCH integrated + controller and want to add that file.
config GBE_BIN_PATH - string "Path to gigabit ethernet firmware" + string "Path to gigabit ethernet configuration" depends on HAVE_GBE_BIN default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/gbe.bin"