22 Sep
2020
22 Sep
'20
10:40 p.m.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45623 )
Change subject: ec/kontron: Fix control flow DEADCODE issue ......................................................................
Patch Set 4:
Seems like it might be simpler to have something like #if KEMPLD_CLK < 0 || KEMPLD_I2C_FREQ_STD < 0 #error Check your KEMPLD_CLK and KEMPLD_I2C_FREQ_STD definitions #endif
That would avoid the dead code and still prevent negative prescaler values here. what do you think?
--
To view, visit https://review.coreboot.org/c/coreboot/+/45623
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic002e708636961358969b2c1eaec0fee5bbcb73a
Gerrit-Change-Number: 45623
Gerrit-PatchSet: 4
Gerrit-Owner: John Zhao john.zhao@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 22 Sep 2020 20:40:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment