Attention is currently required from: Ravi Kumar Bokka, Paul Menzel, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63026 )
Change subject: soc/qualcomm/common: update size of memchipinfo structure ......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63026/comment/b6906275_f88f491a PS5, Line 7: soc/qualcomm/common: update size of memchipinfo structure That is not what this patch does. This one actually fixes the bugs from CB:59195
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/63026/comment/58b70608_1e7b4adc PS5, Line 30: uint64_t * Is said "this cast is unnecessary". I did not say "please change this to a uint64_t* cast". Neither te->blob_address nor mem_chip_addr is actually a uint64_t*. How did you even come up with that?
I just want you to remove these parenthesis and everything in them so that this line reads:
mem_chip_addr = te->blob_address;