Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44947 )
Change subject: util/mb/google: Update dalboz/trembyle template ......................................................................
Patch Set 1:
Patch Set 1:
This looks okay to me, but one thing to consider here is that spd/ directory will not be present under the variant directory when a new variant is added using this script. Do we just want to leave this spd/ addition to Makefile here and in follow-up CLs, memory parts should get added? Would that be the workflow?
How about we add an empty spd/mem_parts_used.txt and a spd/Makefile.inc with an empty SPD_SOURCES. That would create the structure and hint that these files need to be configured for the variant.
With a one line change to gen_part_id.go we can enable comments in mem_parts_used.txt. Then we can add instructions at the top of the empty mem_parts_used.txt.