Attention is currently required from: Alexander Couzens, Andrey Petrov, Angel Pons, Arthur Heymans, Caveh Jalali, Christian Walter, Cliff Huang, Dinesh Gehlot, Eran Mitrani, Forest Mittelberg, Hung-Te Lin, Jakub Czapiga, Jason Nien, Johnny Lin, Jonathan Zhang, Julius Werner, Jérémy Compostella, Kapil Porwal, Lance Zhao, Lean Sheng Tan, Martin Roth, Michał Żygowski, Nick Vaccaro, Patrick Rudolph, Piotr Król, Ronak Kanabar, Shuo Liu, Subrata Banik, Tarun, Tim Chu, Tim Wawrzynczak, Yidi Lin, Yu-Ping Wu.
Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82665?usp=email )
Change subject: tree: Use <stdio.h> for snprintf ......................................................................
tree: Use <stdio.h> for snprintf
<stdio.h> header is used for input/output operations (such as printf, scanf, fopen, etc.). Although some input/output functions can manipulate strings, they do not need to directly include <string.h> because they are declared independently.
Change-Id: Ibe2a4ff6f68843a6d99cfdfe182cf2dd922802aa Signed-off-by: Elyes Haouas ehaouas@noos.fr --- M src/acpi/acpigen.c M src/acpi/acpigen_dptf.c M src/acpi/acpigen_usb.c M src/acpi/device.c M src/arch/arm64/smbios.c M src/arch/x86/smbios.c M src/console/vsprintf.c M src/cpu/x86/smm/smm_module_loader.c M src/device/device_util.c M src/device/dram/ddr2.c M src/device/pci_rom.c M src/drivers/acpi/thermal_zone/thermal_zone.c M src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c M src/drivers/generic/gpio_keys/gpio_keys.c M src/drivers/i2c/cs35l53/cs35l53.c M src/drivers/i2c/generic/generic.c M src/drivers/i2c/gpiomux/bus/bus.c M src/drivers/i2c/gpiomux/mux/mux.c M src/drivers/i2c/hid/hid.c M src/drivers/i2c/max98390/max98390.c M src/drivers/i2c/max98396/max98396.c M src/drivers/i2c/rt1011/rt1011.c M src/drivers/i2c/rt5645/rt5645.c M src/drivers/i2c/sx9310/sx9310.c M src/drivers/i2c/sx9324/sx9324.c M src/drivers/i2c/sx9360/sx9360.c M src/drivers/intel/dptf/dptf.c M src/drivers/intel/fsp2_0/util.c M src/drivers/intel/gma/acpi.c M src/drivers/intel/mipi_camera/camera.c M src/drivers/intel/pmc_mux/conn/conn.c M src/drivers/intel/usb4/retimer/retimer.c M src/drivers/nxp/uwb/uwb.c M src/drivers/ocp/dmi/smbios.c M src/drivers/spi/acpi/acpi.c M src/drivers/uart/acpi/acpi.c M src/drivers/usb/hub/acpi.c M src/drivers/usb/pci_xhci/pci_xhci.c M src/drivers/wifi/generic/acpi.c M src/ec/clevo/it5570e/ssdt.c M src/ec/google/chromeec/audio_codec/audio_codec.c M src/ec/google/chromeec/ec_dptf_helpers.c M src/ec/google/chromeec/ec_smbios.c M src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c M src/ec/google/chromeec/mux/conn/conn.c M src/ec/lenovo/h8/h8.c M src/ec/lenovo/h8/ssdt.c M src/include/stdio.h M src/include/string.h M src/lib/device_tree.c M src/lib/fit.c M src/lib/smbios.c M src/lib/smbios_defaults.c M src/lib/ux_locales.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/poppy/variants/nami/mainboard.c M src/mainboard/google/poppy/variants/nautilus/mainboard.c M src/mainboard/google/poppy/variants/rammus/mainboard.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/rex/mainboard.c M src/mainboard/google/volteer/mainboard.c M src/mainboard/ibm/sbp1/ramstage.c M src/mainboard/intel/adlrvp/mainboard.c M src/mainboard/intel/mtlrvp/mainboard.c M src/mainboard/intel/tglrvp/mainboard.c M src/mainboard/kontron/986lcd-m/mainboard.c M src/mainboard/lenovo/s230u/mainboard.c M src/mainboard/ocp/deltalake/ramstage.c M src/mainboard/pcengines/apu2/mainboard.c M src/mainboard/prodrive/atlas/mainboard.c M src/mainboard/prodrive/atlas/vpd.c M src/mainboard/prodrive/hermes/mainboard.c M src/mainboard/prodrive/hermes/smbios.c M src/security/tpm/tspi/crtm.c M src/soc/cavium/cn81xx/soc.c M src/soc/intel/common/block/acpi/cpu_hybrid.c M src/soc/intel/xeon_sp/acpi.c M src/soc/mediatek/common/display.c M src/southbridge/intel/common/rcba_pirq.c M src/southbridge/intel/lynxpoint/acpi.c M src/superio/common/ssdt.c M tests/stubs/die.c M util/cbfstool/flashmap/kv_pair.c 86 files changed, 86 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/82665/1
diff --git a/src/acpi/acpigen.c b/src/acpi/acpigen.c index 9c04e84..4049df0 100644 --- a/src/acpi/acpigen.c +++ b/src/acpi/acpigen.c @@ -14,6 +14,7 @@ #include <console/console.h> #include <device/device.h> #include <device/soundwire.h> +#include <stdio.h> #include <types.h>
static char *gencurrent; diff --git a/src/acpi/acpigen_dptf.c b/src/acpi/acpigen_dptf.c index aa8de1e..b28dcc6 100644 --- a/src/acpi/acpigen_dptf.c +++ b/src/acpi/acpigen_dptf.c @@ -4,6 +4,7 @@ #include <acpi/acpigen_dptf.h> #include <stdbool.h> #include <stdint.h> +#include <stdio.h>
/* Defaults */ #define DEFAULT_RAW_UNIT "ma" diff --git a/src/acpi/acpigen_usb.c b/src/acpi/acpigen_usb.c index 221a215..c285360 100644 --- a/src/acpi/acpigen_usb.c +++ b/src/acpi/acpigen_usb.c @@ -5,6 +5,7 @@ #include <acpi/acpigen.h> #include <acpi/acpigen_usb.h> #include <device/device.h> +#include <stdio.h>
static const char *power_role_to_str(enum usb_typec_power_role power_role) { diff --git a/src/acpi/device.c b/src/acpi/device.c index 7313639..af3d262 100644 --- a/src/acpi/device.c +++ b/src/acpi/device.c @@ -8,6 +8,7 @@ #include <acpi/acpigen_pci.h> #include <device/device.h> #include <stdlib.h> +#include <stdio.h> #include <types.h> #include <crc_byte.h>
diff --git a/src/arch/arm64/smbios.c b/src/arch/arm64/smbios.c index ede48e6..520c287 100644 --- a/src/arch/arm64/smbios.c +++ b/src/arch/arm64/smbios.c @@ -5,6 +5,7 @@ #include <arch/smc.h> #include <console/console.h> #include <smbios.h> +#include <stdio.h> #include <string.h>
static void smbios_processor_id(u32 *processor_id) diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index a2038b6..b5175c8 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <arch/cpu.h> #include <cpu/x86/name.h> +#include <stdio.h>
static int smbios_cpu_vendor(u8 *start) { diff --git a/src/console/vsprintf.c b/src/console/vsprintf.c index 06b9e49..4ffc677 100644 --- a/src/console/vsprintf.c +++ b/src/console/vsprintf.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <console/vtxprintf.h> +#include <stdio.h> #include <string.h>
struct vsnprintf_context { diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c index 02debfc..646f3bb 100644 --- a/src/cpu/x86/smm/smm_module_loader.c +++ b/src/cpu/x86/smm/smm_module_loader.c @@ -11,6 +11,7 @@ #include <device/mmio.h> #include <rmodule.h> #include <smmstore.h> +#include <stdio.h> #include <string.h> #include <types.h>
diff --git a/src/device/device_util.c b/src/device/device_util.c index d91df76..056aa51 100644 --- a/src/device/device_util.c +++ b/src/device/device_util.c @@ -4,6 +4,7 @@ #include <console/console.h> #include <device/device.h> #include <device/pci_def.h> +#include <stdio.h> #include <stdlib.h> #include <string.h> #include <types.h> diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c index ce7a3bf..332bb12 100644 --- a/src/device/dram/ddr2.c +++ b/src/device/dram/ddr2.c @@ -10,6 +10,7 @@ #include <device/device.h> #include <device/dram/ddr2.h> #include <lib.h> +#include <stdio.h> #include <string.h> #include <types.h>
diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c index 7679552..d60720e 100644 --- a/src/device/pci_rom.c +++ b/src/device/pci_rom.c @@ -6,6 +6,7 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> +#include <stdio.h> #include <string.h> #include <cbfs.h> #include <cbmem.h> diff --git a/src/drivers/acpi/thermal_zone/thermal_zone.c b/src/drivers/acpi/thermal_zone/thermal_zone.c index ef95bed..b1016cd 100644 --- a/src/drivers/acpi/thermal_zone/thermal_zone.c +++ b/src/drivers/acpi/thermal_zone/thermal_zone.c @@ -5,6 +5,7 @@ #include <commonlib/bsd/helpers.h> #include <console/console.h> #include <device/device.h> +#include <stdio.h> #include <stdlib.h> #include <string.h>
diff --git a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c index 16ae48d..28377a1 100644 --- a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c +++ b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c @@ -3,6 +3,7 @@ #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h" #include <console/console.h> diff --git a/src/drivers/generic/gpio_keys/gpio_keys.c b/src/drivers/generic/gpio_keys/gpio_keys.c index 37b90ca..97a4e05 100644 --- a/src/drivers/generic/gpio_keys/gpio_keys.c +++ b/src/drivers/generic/gpio_keys/gpio_keys.c @@ -3,6 +3,7 @@ #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <device/device.h> +#include <stdio.h> #include <string.h>
#include "chip.h" diff --git a/src/drivers/i2c/cs35l53/cs35l53.c b/src/drivers/i2c/cs35l53/cs35l53.c index 479ef7f..974a647 100644 --- a/src/drivers/i2c/cs35l53/cs35l53.c +++ b/src/drivers/i2c/cs35l53/cs35l53.c @@ -6,6 +6,7 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> +#include <stdio.h>
#include "chip.h"
diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index a2d510b..a3d8ef2 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -7,6 +7,7 @@ #include <device/i2c_simple.h> #include <device/device.h> #include <gpio.h> +#include <stdio.h> #include <string.h> #include "chip.h"
diff --git a/src/drivers/i2c/gpiomux/bus/bus.c b/src/drivers/i2c/gpiomux/bus/bus.c index 5487f6d..8efcf21 100644 --- a/src/drivers/i2c/gpiomux/bus/bus.c +++ b/src/drivers/i2c/gpiomux/bus/bus.c @@ -4,6 +4,7 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> +#include <stdio.h> #include <string.h>
#include "chip.h" diff --git a/src/drivers/i2c/gpiomux/mux/mux.c b/src/drivers/i2c/gpiomux/mux/mux.c index 91d4ebf..a7dcd64 100644 --- a/src/drivers/i2c/gpiomux/mux/mux.c +++ b/src/drivers/i2c/gpiomux/mux/mux.c @@ -4,6 +4,7 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> +#include <stdio.h> #include <string.h>
#include "chip.h" diff --git a/src/drivers/i2c/hid/hid.c b/src/drivers/i2c/hid/hid.c index fb3a439..06b31d1 100644 --- a/src/drivers/i2c/hid/hid.c +++ b/src/drivers/i2c/hid/hid.c @@ -4,6 +4,7 @@ #include <acpi/acpi_device.h> #include <assert.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h" #include <gpio.h> diff --git a/src/drivers/i2c/max98390/max98390.c b/src/drivers/i2c/max98390/max98390.c index f4912c1..dced120 100644 --- a/src/drivers/i2c/max98390/max98390.c +++ b/src/drivers/i2c/max98390/max98390.c @@ -7,6 +7,7 @@ #include <device/device.h> #include <identity.h> #include <stdint.h> +#include <stdio.h> #include <vendorcode/google/dsm_calib.h> #include "chip.h"
diff --git a/src/drivers/i2c/max98396/max98396.c b/src/drivers/i2c/max98396/max98396.c index ca07dbd..f71873a 100644 --- a/src/drivers/i2c/max98396/max98396.c +++ b/src/drivers/i2c/max98396/max98396.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> +#include <stdio.h>
#include "chip.h"
diff --git a/src/drivers/i2c/rt1011/rt1011.c b/src/drivers/i2c/rt1011/rt1011.c index e8ee8df..08a0fac 100644 --- a/src/drivers/i2c/rt1011/rt1011.c +++ b/src/drivers/i2c/rt1011/rt1011.c @@ -6,6 +6,7 @@ #include <device/i2c.h> #include <device/device.h> #include <stdint.h> +#include <stdio.h> #include <vendorcode/google/dsm_calib.h> #include "chip.h"
diff --git a/src/drivers/i2c/rt5645/rt5645.c b/src/drivers/i2c/rt5645/rt5645.c index 28434ee..ea3837f 100644 --- a/src/drivers/i2c/rt5645/rt5645.c +++ b/src/drivers/i2c/rt5645/rt5645.c @@ -4,6 +4,8 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> +#include <stdio.h> + #include "chip.h"
#define RT5645_ACPI_NAME "RT58" diff --git a/src/drivers/i2c/sx9310/sx9310.c b/src/drivers/i2c/sx9310/sx9310.c index e5142bc..a4bdb15 100644 --- a/src/drivers/i2c/sx9310/sx9310.c +++ b/src/drivers/i2c/sx9310/sx9310.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h"
diff --git a/src/drivers/i2c/sx9324/sx9324.c b/src/drivers/i2c/sx9324/sx9324.c index 966726f..041991e 100644 --- a/src/drivers/i2c/sx9324/sx9324.c +++ b/src/drivers/i2c/sx9324/sx9324.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h"
diff --git a/src/drivers/i2c/sx9360/sx9360.c b/src/drivers/i2c/sx9360/sx9360.c index df154f4..d72f28d 100644 --- a/src/drivers/i2c/sx9360/sx9360.c +++ b/src/drivers/i2c/sx9360/sx9360.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h"
diff --git a/src/drivers/intel/dptf/dptf.c b/src/drivers/intel/dptf/dptf.c index 5bbbc1b..b6f5005 100644 --- a/src/drivers/intel/dptf/dptf.c +++ b/src/drivers/intel/dptf/dptf.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <device/device.h> #include <intelblocks/pmc_ipc.h> +#include <stdio.h> #include <soc/dptf.h> #include <soc/pci_devs.h> #include "chip.h" diff --git a/src/drivers/intel/fsp2_0/util.c b/src/drivers/intel/fsp2_0/util.c index 47dc3e8..d09b39b 100644 --- a/src/drivers/intel/fsp2_0/util.c +++ b/src/drivers/intel/fsp2_0/util.c @@ -8,6 +8,7 @@ #include <commonlib/fsp.h> #include <console/console.h> #include <fsp/util.h> +#include <stdio.h> #include <string.h> #include <types.h> #include <assert.h> diff --git a/src/drivers/intel/gma/acpi.c b/src/drivers/intel/gma/acpi.c index 2ee1d63..534c0d8 100644 --- a/src/drivers/intel/gma/acpi.c +++ b/src/drivers/intel/gma/acpi.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <acpi/acpigen.h> +#include <stdio.h> #include <string.h> #include "i915.h"
diff --git a/src/drivers/intel/mipi_camera/camera.c b/src/drivers/intel/mipi_camera/camera.c index 190adc7..63a409a 100644 --- a/src/drivers/intel/mipi_camera/camera.c +++ b/src/drivers/intel/mipi_camera/camera.c @@ -9,6 +9,8 @@ #include <device/i2c_simple.h> #include <device/device.h> #include <device/pci_def.h> +#include <stdio.h> + #include "chip.h"
#define CSI2_DATA_STREAM_INTERFACE_GUID \ diff --git a/src/drivers/intel/pmc_mux/conn/conn.c b/src/drivers/intel/pmc_mux/conn/conn.c index 4b1b08c..dda1fe0 100644 --- a/src/drivers/intel/pmc_mux/conn/conn.c +++ b/src/drivers/intel/pmc_mux/conn/conn.c @@ -7,6 +7,7 @@ #include <console/console.h> #include <drivers/usb/acpi/chip.h> #include <intelblocks/acpi.h> +#include <stdio.h>
#include "chip.h"
diff --git a/src/drivers/intel/usb4/retimer/retimer.c b/src/drivers/intel/usb4/retimer/retimer.c index 9e627de..3c867d4 100644 --- a/src/drivers/intel/usb4/retimer/retimer.c +++ b/src/drivers/intel/usb4/retimer/retimer.c @@ -7,6 +7,7 @@ #include <device/device.h> #include <drivers/usb/acpi/chip.h> #include <gpio.h> +#include <stdio.h> #include <string.h> #include "chip.h" #include "retimer.h" diff --git a/src/drivers/nxp/uwb/uwb.c b/src/drivers/nxp/uwb/uwb.c index 590b3f5..3c4fac1 100644 --- a/src/drivers/nxp/uwb/uwb.c +++ b/src/drivers/nxp/uwb/uwb.c @@ -6,6 +6,7 @@ #include <device/device.h> #include <device/spi.h> #include <spi-generic.h> +#include <stdio.h> #include <string.h> #include "chip.h"
diff --git a/src/drivers/ocp/dmi/smbios.c b/src/drivers/ocp/dmi/smbios.c index ead9b4d..0ac3334 100644 --- a/src/drivers/ocp/dmi/smbios.c +++ b/src/drivers/ocp/dmi/smbios.c @@ -6,6 +6,7 @@ #include <delay.h> #include <cpu/x86/mp.h> #include <timer.h> +#include <stdio.h> #include <string.h> #include <soc/soc_util.h> #include <soc/util.h> diff --git a/src/drivers/spi/acpi/acpi.c b/src/drivers/spi/acpi/acpi.c index e87946f..75d6dc9 100644 --- a/src/drivers/spi/acpi/acpi.c +++ b/src/drivers/spi/acpi/acpi.c @@ -6,6 +6,7 @@ #include <device/device.h> #include <device/spi.h> #include <spi-generic.h> +#include <stdio.h> #include <string.h> #include "chip.h"
diff --git a/src/drivers/uart/acpi/acpi.c b/src/drivers/uart/acpi/acpi.c index a245f2c..716d522 100644 --- a/src/drivers/uart/acpi/acpi.c +++ b/src/drivers/uart/acpi/acpi.c @@ -3,6 +3,7 @@ #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <console/console.h> +#include <stdio.h> #include <string.h> #include "chip.h"
diff --git a/src/drivers/usb/hub/acpi.c b/src/drivers/usb/hub/acpi.c index ebbe4b2..15732a8 100644 --- a/src/drivers/usb/hub/acpi.c +++ b/src/drivers/usb/hub/acpi.c @@ -2,6 +2,7 @@
#include <acpi/acpigen.h> #include <acpi/acpi_device.h> +#include <stdio.h>
#include "chip.h"
diff --git a/src/drivers/usb/pci_xhci/pci_xhci.c b/src/drivers/usb/pci_xhci/pci_xhci.c index 47f69c0..b898642 100644 --- a/src/drivers/usb/pci_xhci/pci_xhci.c +++ b/src/drivers/usb/pci_xhci/pci_xhci.c @@ -7,6 +7,7 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/xhci.h> +#include <stdio.h> #include <stdlib.h>
#define PCI_XHCI_CLASSCODE 0x0c0330 /* USB3.0 xHCI controller */ diff --git a/src/drivers/wifi/generic/acpi.c b/src/drivers/wifi/generic/acpi.c index 9e2936d..fd1da06 100644 --- a/src/drivers/wifi/generic/acpi.c +++ b/src/drivers/wifi/generic/acpi.c @@ -7,6 +7,7 @@ #include <device/pci_ids.h> #include <mtcl.h> #include <sar.h> +#include <stdio.h> #include <stdlib.h> #include <wrdd.h>
diff --git a/src/ec/clevo/it5570e/ssdt.c b/src/ec/clevo/it5570e/ssdt.c index a0d746a..b5a5774 100644 --- a/src/ec/clevo/it5570e/ssdt.c +++ b/src/ec/clevo/it5570e/ssdt.c @@ -4,6 +4,7 @@ #include <console/console.h> #include <device/device.h> #include <device/mmio.h> +#include <stdio.h>
#include "chip.h" #include "ec.h" diff --git a/src/ec/google/chromeec/audio_codec/audio_codec.c b/src/ec/google/chromeec/audio_codec/audio_codec.c index a8def98..fe2a459 100644 --- a/src/ec/google/chromeec/audio_codec/audio_codec.c +++ b/src/ec/google/chromeec/audio_codec/audio_codec.c @@ -5,6 +5,8 @@ #include <console/console.h> #include <device/device.h> #include <device/path.h> +#include <stdio.h> + #include "chip.h"
#define CROS_EC_AUDIO_CODEC_HID "GOOG0013" diff --git a/src/ec/google/chromeec/ec_dptf_helpers.c b/src/ec/google/chromeec/ec_dptf_helpers.c index c44138f..3034010 100644 --- a/src/ec/google/chromeec/ec_dptf_helpers.c +++ b/src/ec/google/chromeec/ec_dptf_helpers.c @@ -4,6 +4,7 @@ #include <acpi/acpigen_dptf.h> #include <ec/google/common/dptf.h> #include <drivers/intel/dptf/chip.h> +#include <stdio.h>
#include "chip.h" /* diff --git a/src/ec/google/chromeec/ec_smbios.c b/src/ec/google/chromeec/ec_smbios.c index d804f64..e175c09 100644 --- a/src/ec/google/chromeec/ec_smbios.c +++ b/src/ec/google/chromeec/ec_smbios.c @@ -3,6 +3,7 @@ #include <stddef.h> #include <ec/google/chromeec/ec.h> #include <console/console.h> +#include <stdio.h> #include <string.h> #include <smbios.h>
diff --git a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c index 64812d4..fc6b759 100644 --- a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c +++ b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <device/device.h> #include <device/path.h> +#include <stdio.h> #include <string.h> #include "chip.h"
diff --git a/src/ec/google/chromeec/mux/conn/conn.c b/src/ec/google/chromeec/mux/conn/conn.c index bb3129b..1200b5c 100644 --- a/src/ec/google/chromeec/mux/conn/conn.c +++ b/src/ec/google/chromeec/mux/conn/conn.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <acpi/acpigen.h> +#include <stdio.h>
#include "chip.h"
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c index 35ca1d9..155a013 100644 --- a/src/ec/lenovo/h8/h8.c +++ b/src/ec/lenovo/h8/h8.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <device/pnp.h> #include <ec/acpi/ec.h> +#include <stdio.h> #include <string.h> #include <smbios.h> #include <option.h> diff --git a/src/ec/lenovo/h8/ssdt.c b/src/ec/lenovo/h8/ssdt.c index 5dc334f..7d7bfac 100644 --- a/src/ec/lenovo/h8/ssdt.c +++ b/src/ec/lenovo/h8/ssdt.c @@ -2,6 +2,7 @@
#include <console/console.h> #include <acpi/acpigen.h> +#include <stdio.h> #include <string.h>
#include "h8.h" diff --git a/src/include/stdio.h b/src/include/stdio.h index d59b941..fe7cb58 100644 --- a/src/include/stdio.h +++ b/src/include/stdio.h @@ -1,8 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
/** - * Note: This file is only for POSIX compatibility, and is meant to be - * chain-included via string.h. + * Note: This file is only for POSIX compatibility. */
#ifndef STDIO_H diff --git a/src/include/string.h b/src/include/string.h index 4a06556..33f0dfe 100644 --- a/src/include/string.h +++ b/src/include/string.h @@ -4,7 +4,6 @@ #define STRING_H
#include <stddef.h> -#include <stdio.h> /* IWYU pragma: export */
void *memcpy(void *dest, const void *src, size_t n); void *memmove(void *dest, const void *src, size_t n); diff --git a/src/lib/device_tree.c b/src/lib/device_tree.c index 2bfd5dd..aff9e15 100644 --- a/src/lib/device_tree.c +++ b/src/lib/device_tree.c @@ -8,6 +8,7 @@ #include <endian.h> #include <stdbool.h> #include <stdint.h> +#include <stdio.h> #include <string.h> #include <stddef.h> #include <stdlib.h> diff --git a/src/lib/fit.c b/src/lib/fit.c index 46ac972..7f0fe67 100644 --- a/src/lib/fit.c +++ b/src/lib/fit.c @@ -12,6 +12,7 @@ #include <memrange.h> #include <fit.h> #include <boardid.h> +#include <stdio.h> #include <stdlib.h> #include <types.h>
diff --git a/src/lib/smbios.c b/src/lib/smbios.c index dcf12bf..ca71e3b 100644 --- a/src/lib/smbios.c +++ b/src/lib/smbios.c @@ -16,6 +16,7 @@ #include <device/pci_ids.h> #include <device/pci.h> #include <drivers/vpd/vpd.h> +#include <stdio.h> #include <stdlib.h>
static u8 smbios_checksum(u8 *p, u32 length) diff --git a/src/lib/smbios_defaults.c b/src/lib/smbios_defaults.c index 8b62ebb..56bddab 100644 --- a/src/lib/smbios_defaults.c +++ b/src/lib/smbios_defaults.c @@ -3,6 +3,7 @@ #include <memory_info.h> #include <smbios.h> #include <stdint.h> +#include <stdio.h> #include <string.h>
/* this function will fill the corresponding locator */ diff --git a/src/lib/ux_locales.c b/src/lib/ux_locales.c index 0a285d9..b389548 100644 --- a/src/lib/ux_locales.c +++ b/src/lib/ux_locales.c @@ -4,6 +4,7 @@ #include <console/console.h> #include <security/vboot/misc.h> #include <stddef.h> +#include <stdio.h> #include <string.h> #include <ux_locales.h> #include <vb2_api.h> diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c index 0d631cc..257a27f 100644 --- a/src/mainboard/google/fizz/mainboard.c +++ b/src/mainboard/google/fizz/mainboard.c @@ -14,6 +14,7 @@ #include <smbios.h> #include <soc/pci_devs.h> #include <soc/nhlt.h> +#include <stdio.h> #include <string.h> #include <timer.h>
diff --git a/src/mainboard/google/gru/sdram_configs.c b/src/mainboard/google/gru/sdram_configs.c index 64f45de..971b671 100644 --- a/src/mainboard/google/gru/sdram_configs.c +++ b/src/mainboard/google/gru/sdram_configs.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <gpio.h> #include <soc/sdram.h> +#include <stdio.h> #include <string.h> #include <types.h>
diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c index 427f094..1290b97 100644 --- a/src/mainboard/google/kahlee/mainboard.c +++ b/src/mainboard/google/kahlee/mainboard.c @@ -16,6 +16,7 @@ #include <soc/acpi.h> #include <soc/pci_devs.h> #include <soc/southbridge.h> +#include <stdio.h> #include <amdblocks/acpimmio.h> #include <variant/ec.h> #include <variant/thermal.h> diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index 69047fa..bc70db5 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -19,6 +19,7 @@ #include <soc/mtcmos.h> #include <soc/spm.h> #include <soc/usb.h> +#include <stdio.h> #include <string.h>
#include "gpio.h" diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index aaa51dd..172581f 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -13,6 +13,7 @@ #include <intelblocks/power_limit.h> #include <smbios.h> #include <soc/ramstage.h> +#include <stdio.h> #include <string.h> #include <variant/sku.h> #include <gpio.h> diff --git a/src/mainboard/google/poppy/variants/nautilus/mainboard.c b/src/mainboard/google/poppy/variants/nautilus/mainboard.c index 7350fb0..d21acd6 100644 --- a/src/mainboard/google/poppy/variants/nautilus/mainboard.c +++ b/src/mainboard/google/poppy/variants/nautilus/mainboard.c @@ -6,6 +6,7 @@ #include <device/device.h> #include <device/pci_ops.h> #include <smbios.h> +#include <stdio.h> #include <string.h> #include <variant/sku.h>
diff --git a/src/mainboard/google/poppy/variants/rammus/mainboard.c b/src/mainboard/google/poppy/variants/rammus/mainboard.c index 90cf7ce..e8c7e69 100644 --- a/src/mainboard/google/poppy/variants/rammus/mainboard.c +++ b/src/mainboard/google/poppy/variants/rammus/mainboard.c @@ -3,6 +3,7 @@ #include <baseboard/variants.h> #include <ec/google/chromeec/ec.h> #include <smbios.h> +#include <stdio.h> #include <string.h> #include <sar.h>
diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c index ff3bb36..4b1b32d 100644 --- a/src/mainboard/google/reef/mainboard.c +++ b/src/mainboard/google/reef/mainboard.c @@ -10,6 +10,7 @@ #include <nhlt.h> #include <smbios.h> #include <soc/nhlt.h> +#include <stdio.h> #include <string.h> #include <variant/ec.h> #include <variant/gpio.h> diff --git a/src/mainboard/google/rex/mainboard.c b/src/mainboard/google/rex/mainboard.c index bf489ff..9157abb 100644 --- a/src/mainboard/google/rex/mainboard.c +++ b/src/mainboard/google/rex/mainboard.c @@ -9,6 +9,7 @@ #include <ec/ec.h> #include <fw_config.h> #include <soc/ramstage.h> +#include <stdio.h> #include <stdlib.h> #include <vendorcode/google/chromeos/chromeos.h>
diff --git a/src/mainboard/google/volteer/mainboard.c b/src/mainboard/google/volteer/mainboard.c index fba9664..ae7519e 100644 --- a/src/mainboard/google/volteer/mainboard.c +++ b/src/mainboard/google/volteer/mainboard.c @@ -12,6 +12,7 @@ #include <intelblocks/tcss.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> +#include <stdio.h> #include <variant/gpio.h> #include <vb2_api.h>
diff --git a/src/mainboard/ibm/sbp1/ramstage.c b/src/mainboard/ibm/sbp1/ramstage.c index d748b1b..98aa999 100644 --- a/src/mainboard/ibm/sbp1/ramstage.c +++ b/src/mainboard/ibm/sbp1/ramstage.c @@ -2,6 +2,7 @@ #include <cpu/x86/smm.h> #include <soc/ramstage.h> #include <soc/smmrelocate.h> +#include <stdio.h>
#include "include/spr_sbp1_gpio.h" #include <bootstate.h> diff --git a/src/mainboard/intel/adlrvp/mainboard.c b/src/mainboard/intel/adlrvp/mainboard.c index 9ac480d..f6321e8 100644 --- a/src/mainboard/intel/adlrvp/mainboard.c +++ b/src/mainboard/intel/adlrvp/mainboard.c @@ -11,6 +11,7 @@ #include <smbios.h> #include <soc/gpio.h> #include <stdint.h> +#include <stdio.h> #include <string.h>
#include "board_id.h" diff --git a/src/mainboard/intel/mtlrvp/mainboard.c b/src/mainboard/intel/mtlrvp/mainboard.c index 2e515f7..85c2dd4 100644 --- a/src/mainboard/intel/mtlrvp/mainboard.c +++ b/src/mainboard/intel/mtlrvp/mainboard.c @@ -8,6 +8,7 @@ #include <soc/ramstage.h> #include <smbios.h> #include <stdint.h> +#include <stdio.h> #include <string.h>
const char *smbios_system_sku(void) diff --git a/src/mainboard/intel/tglrvp/mainboard.c b/src/mainboard/intel/tglrvp/mainboard.c index bbce927..8f38ca2 100644 --- a/src/mainboard/intel/tglrvp/mainboard.c +++ b/src/mainboard/intel/tglrvp/mainboard.c @@ -6,6 +6,7 @@ #include <ec/ec.h> #include <soc/gpio.h> #include <smbios.h> +#include <stdio.h> #include <string.h>
const char *smbios_system_sku(void) diff --git a/src/mainboard/kontron/986lcd-m/mainboard.c b/src/mainboard/kontron/986lcd-m/mainboard.c index dbdd059..01815ed 100644 --- a/src/mainboard/kontron/986lcd-m/mainboard.c +++ b/src/mainboard/kontron/986lcd-m/mainboard.c @@ -6,6 +6,7 @@ #include <console/console.h> #include <drivers/intel/gma/int15.h> #include <option.h> +#include <stdio.h> #include <superio/hwm5_conf.h> #include <superio/nuvoton/common/hwm.h>
diff --git a/src/mainboard/lenovo/s230u/mainboard.c b/src/mainboard/lenovo/s230u/mainboard.c index b5e3b87..f51ec67 100644 --- a/src/mainboard/lenovo/s230u/mainboard.c +++ b/src/mainboard/lenovo/s230u/mainboard.c @@ -5,6 +5,7 @@ #include <drivers/intel/gma/int15.h> #include <ec/acpi/ec.h> #include <southbridge/intel/common/gpio.h> +#include <stdio.h> #include <string.h> #include <smbios.h> #include "ec.h" diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c index 6dd7c10..55a10ad 100644 --- a/src/mainboard/ocp/deltalake/ramstage.c +++ b/src/mainboard/ocp/deltalake/ramstage.c @@ -20,6 +20,7 @@ #include <soc/smmrelocate.h> #include <soc/soc_util.h> #include <soc/util.h> +#include <stdio.h> #include <string.h> #include <types.h>
diff --git a/src/mainboard/pcengines/apu2/mainboard.c b/src/mainboard/pcengines/apu2/mainboard.c index ac5c928..b21c7ed 100644 --- a/src/mainboard/pcengines/apu2/mainboard.c +++ b/src/mainboard/pcengines/apu2/mainboard.c @@ -16,6 +16,7 @@ #include <southbridge/amd/common/amd_pci_util.h> #include <superio/nuvoton/nct5104d/nct5104d.h> #include <smbios.h> +#include <stdio.h> #include <string.h> #include <AGESA.h> #include "gpio_ftns.h" diff --git a/src/mainboard/prodrive/atlas/mainboard.c b/src/mainboard/prodrive/atlas/mainboard.c index 0128670..a70bbae 100644 --- a/src/mainboard/prodrive/atlas/mainboard.c +++ b/src/mainboard/prodrive/atlas/mainboard.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <gpio.h> #include <smbios.h> +#include <stdio.h> #include <string.h> #include <types.h>
diff --git a/src/mainboard/prodrive/atlas/vpd.c b/src/mainboard/prodrive/atlas/vpd.c index ba249a9..badbc6e 100644 --- a/src/mainboard/prodrive/atlas/vpd.c +++ b/src/mainboard/prodrive/atlas/vpd.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <console/console.h> +#include <stdio.h> #include <string.h> #include <types.h>
diff --git a/src/mainboard/prodrive/hermes/mainboard.c b/src/mainboard/prodrive/hermes/mainboard.c index b0bf0dd..6d0da8d 100644 --- a/src/mainboard/prodrive/hermes/mainboard.c +++ b/src/mainboard/prodrive/hermes/mainboard.c @@ -16,6 +16,7 @@ #include <intelblocks/pmclib.h> #include <smbios.h> #include <soc/pm.h> +#include <stdio.h> #include <string.h> #include <types.h>
diff --git a/src/mainboard/prodrive/hermes/smbios.c b/src/mainboard/prodrive/hermes/smbios.c index 923ce81..9671555 100644 --- a/src/mainboard/prodrive/hermes/smbios.c +++ b/src/mainboard/prodrive/hermes/smbios.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <smbios.h> +#include <stdio.h> #include <string.h> #include <types.h>
diff --git a/src/security/tpm/tspi/crtm.c b/src/security/tpm/tspi/crtm.c index 621d7cd..4e0a9b7 100644 --- a/src/security/tpm/tspi/crtm.c +++ b/src/security/tpm/tspi/crtm.c @@ -6,6 +6,7 @@ #include <cbfs.h> #include <symbols.h> #include "crtm.h" +#include <stdio.h> #include <string.h>
static int tpm_log_initialized; diff --git a/src/soc/cavium/cn81xx/soc.c b/src/soc/cavium/cn81xx/soc.c index 5e606d3..81c9a64 100644 --- a/src/soc/cavium/cn81xx/soc.c +++ b/src/soc/cavium/cn81xx/soc.c @@ -13,6 +13,7 @@ #include <soc/uart.h> #include <stddef.h> #include <stdlib.h> +#include <stdio.h> #include <string.h> #include <symbols.h> #include <libbdk-boot/bdk-boot.h> diff --git a/src/soc/intel/common/block/acpi/cpu_hybrid.c b/src/soc/intel/common/block/acpi/cpu_hybrid.c index f52b68f..7659310 100644 --- a/src/soc/intel/common/block/acpi/cpu_hybrid.c +++ b/src/soc/intel/common/block/acpi/cpu_hybrid.c @@ -10,6 +10,7 @@ #include <intelblocks/acpi.h> #include <soc/cpu.h> #include <types.h> +#include <stdio.h>
#define CPPC_NOM_FREQ_IDX 22 #define CPPC_NOM_PERF_IDX 3 diff --git a/src/soc/intel/xeon_sp/acpi.c b/src/soc/intel/xeon_sp/acpi.c index 0d66aec..1c493af 100644 --- a/src/soc/intel/xeon_sp/acpi.c +++ b/src/soc/intel/xeon_sp/acpi.c @@ -6,6 +6,7 @@ #include <soc/pci_devs.h> #include <soc/util.h> #include <stdint.h> +#include <stdio.h> #include <stdlib.h>
#include "chip.h" diff --git a/src/soc/mediatek/common/display.c b/src/soc/mediatek/common/display.c index 0dea58c..0c23e49 100644 --- a/src/soc/mediatek/common/display.c +++ b/src/soc/mediatek/common/display.c @@ -10,6 +10,7 @@ #include <soc/dptx.h> #include <soc/dsi.h> #include <soc/mtcmos.h> +#include <stdio.h> #include <string.h>
static struct panel_serializable_data *get_mipi_cmd_from_cbfs(struct panel_description *desc) diff --git a/src/southbridge/intel/common/rcba_pirq.c b/src/southbridge/intel/common/rcba_pirq.c index c9f1518..c9ab140 100644 --- a/src/southbridge/intel/common/rcba_pirq.c +++ b/src/southbridge/intel/common/rcba_pirq.c @@ -4,6 +4,7 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> +#include <stdio.h> #include <stdlib.h> #include <southbridge/intel/common/acpi_pirq_gen.h> #include <southbridge/intel/common/rcba_pirq.h> diff --git a/src/southbridge/intel/lynxpoint/acpi.c b/src/southbridge/intel/lynxpoint/acpi.c index aa6e650..c3aee1f 100644 --- a/src/southbridge/intel/lynxpoint/acpi.c +++ b/src/southbridge/intel/lynxpoint/acpi.c @@ -3,6 +3,7 @@ #include <acpi/acpi.h> #include <acpi/acpi_gnvs.h> #include <acpi/acpigen.h> +#include <stdio.h> #include <string.h> #include <version.h> #include <soc/nvs.h> diff --git a/src/superio/common/ssdt.c b/src/superio/common/ssdt.c index 4fd1eed..a63ca9c 100644 --- a/src/superio/common/ssdt.c +++ b/src/superio/common/ssdt.c @@ -8,6 +8,7 @@ #include <acpi/acpi.h> #include <console/console.h> #include <types.h> +#include <stdio.h> #include <string.h>
struct superio_dev { diff --git a/tests/stubs/die.c b/tests/stubs/die.c index 84bb401..86e5056 100644 --- a/tests/stubs/die.c +++ b/tests/stubs/die.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <stdarg.h> -#include <stdio.h> #include <tests/test.h>
void die(const char *msg, ...) diff --git a/util/cbfstool/flashmap/kv_pair.c b/util/cbfstool/flashmap/kv_pair.c index b711302..5d033b3 100644 --- a/util/cbfstool/flashmap/kv_pair.c +++ b/util/cbfstool/flashmap/kv_pair.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: BSD-3-Clause or GPL-2.0-only */
-#include <stdio.h> #include <stdlib.h> #include <stdarg.h>